analyzer_experimental checkpoint and AnalysisContext example.

analyzer_experimental checkpoint and AnalysisContext example.


R=pquitslund@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=20178

[Brian Wilkerson, 2013-03-18 20:30:57]

https://codereview.chromium.org/12604020/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/12604020/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:651:
|| checkForExtendsOrImplementsDisallowedClass(
This should not be changed. Otherwise we'll stop checking implemented classes on
the first violation rather than checking all of them. The current behavior is
correct.

[scheglov, 2013-03-18 20:34:13]

https://codereview.chromium.org/12604020/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/12604020/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:651:
|| checkForExtendsOrImplementsDisallowedClass(
On 2013/03/18 20:30:57, Brian Wilkerson wrote:
> This should not be changed. Otherwise we'll stop checking implemented classes
on
> the first violation rather than checking all of them. The current behavior is
> correct.

Aha!
Thank you, I will rollback this.

[scheglov, 2013-03-18 20:43:42]

PTAL

[Brian Wilkerson, 2013-03-18 20:45:40]

https://codereview.chromium.org/12604020/diff/1/pkg/analyzer_experimental/exa...
File pkg/analyzer_experimental/example/resolve_driver.dart (right):

https://codereview.chromium.org/12604020/diff/1/pkg/analyzer_experimental/exa...
pkg/analyzer_experimental/example/resolve_driver.dart:35:
changeSet.changed(source);
You shouldn't need to mark a source as changed if you're just adding it (it's
assumed to be out of date if we've never seen it before).

[Brian Wilkerson, 2013-03-18 20:47:46]

The SourceFactory change looks fine. I only looked at that and the example
itself. I assumed Phil could handle the rest (and mostly only looked at the
example out of curiosity).

[scheglov, 2013-03-18 20:50:49]

Well, looking on translated Dart source is not very useful, so changes in Java
sources and example are parts which are important. Thanks for reviewing some of
them!

https://codereview.chromium.org/12604020/diff/1/pkg/analyzer_experimental/exa...
File pkg/analyzer_experimental/example/resolve_driver.dart (right):

https://codereview.chromium.org/12604020/diff/1/pkg/analyzer_experimental/exa...
pkg/analyzer_experimental/example/resolve_driver.dart:35:
changeSet.changed(source);
On 2013/03/18 20:45:40, Brian Wilkerson wrote:
> You shouldn't need to mark a source as changed if you're just adding it (it's
> assumed to be out of date if we've never seen it before).

Done.

[pquitslund, 2013-03-18 21:04:04]

lgtm

https://codereview.chromium.org/12604020/diff/9001/pkg/analyzer_experimental/...
File pkg/analyzer_experimental/example/resolve_driver.dart (right):

https://codereview.chromium.org/12604020/diff/9001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/example/resolve_driver.dart:1: #!/usr/bin/env dart
I would probably rename this to 'resolver_driver.dart'.

[scheglov, 2013-03-18 21:18:13]

Committed patchset #3 manually as r20178 (presubmit successful).