Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 1260283007: Fix race and limit access to mutator_thread_. (Closed)

Created:
5 years, 4 months ago by koda
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix race and limit access to mutator_thread_. Unsynchronized access to the contents of another thread is dangerous, even for just ASSERTs, as shown by issue 23958. Verify the bidirectional Isolate<->Thread pointer invariant when *setting* the mutator_thread_ field, and limit the interface to comparisons with NULL and the current thread. BUG=https://github.com/dart-lang/sdk/issues/23958 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/7d82391e8949513ced7be0ee6cd56b9f4a38fcd8

Patch Set 1 #

Patch Set 2 : Remove debug print. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.h View 2 chunks +17 lines, -10 lines 0 comments Download
M runtime/vm/isolate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/thread_registry.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
5 years, 4 months ago (2015-08-04 20:27:26 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-08-04 20:30:17 UTC) #3
koda
5 years, 4 months ago (2015-08-04 20:30:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7d82391e8949513ced7be0ee6cd56b9f4a38fcd8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698