Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1346)

Issue 1260253005: Switch from AsyncThunk to AsyncMemoizer. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch from AsyncThunk to AsyncMemoizer. Hooray for standard packages! R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/7b8bc4e38e50bc7119603b937b00bd8fb04d8edf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -63 lines) Patch
M lib/src/runner.dart View 4 chunks +6 lines, -5 lines 0 comments Download
M lib/src/runner/browser/compiler_pool.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M lib/src/runner/browser/server.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M lib/src/runner/loader.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M lib/src/runner/runner_suite.dart View 3 chunks +5 lines, -4 lines 0 comments Download
D lib/src/util/async_thunk.dart View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-07-28 21:28:02 UTC) #1
kevmoo
lgtm
5 years, 4 months ago (2015-07-28 22:42:16 UTC) #2
nweiz
5 years, 4 months ago (2015-07-29 00:31:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7b8bc4e38e50bc7119603b937b00bd8fb04d8edf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698