Issue 1260033004: Fix for issue 23244

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1260033004: Fix for issue 23244 (Closed)

Created:
5 years, 4 months ago by siva

Modified:
5 years, 4 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix for issue 23244 Refactoring of WriteObjectImpl and ReadObjectImpl to enable inlining of canonical objects in the snapshot stream. BUG=23244 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b0c9f2ef9bfade41db4536ddde2fc2d8bc382975

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+384 lines, -362 lines)			Patch
M	runtime/vm/dart_api_message.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View		44 chunks	+53 lines, -58 lines	0 comments	Download
M	runtime/vm/snapshot.h	View	1	4 chunks	+18 lines, -8 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View		23 chunks	+250 lines, -292 lines	0 comments	Download
A	tests/language/issue23244_test.dart	View		1 chunk	+59 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

siva

5 years, 4 months ago (2015-07-28 17:52:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:2) manually as
b0c9f2ef9bfade41db4536ddde2fc2d8bc382975 (presubmit successful).