Issue 126003002: Address comments from CL 125123002 and additional cleanup.

Issue 126003002: Address comments from CL 125123002 and additional cleanup. (Closed)

Created:
6 years, 11 months ago by ahe

Modified:
6 years, 11 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Address comments from CL 125123002 and additional cleanup. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=31660

Patch Set 2 : Added README file. #

Total comments: 2

Patch Set 3 : Update copyright year. #

Created: 6 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -39941 lines)			Patch
A	dart/site/try/README	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/site/try/app.yaml	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	dart/site/try/create_manifest.sh	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	dart/site/try/deploy.sh	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	dart/site/try/extracted_themes.dart	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	dart/site/try/iframe.js	View	1 2	1 chunk	+20 lines, -14 lines	0 comments	Download
M	dart/site/try/leap.dart	View	1 2	9 chunks	+65 lines, -54 lines	0 comments	Download
D	dart/site/try/leap.dart.js	View	1 2	1 chunk	+0 lines, -15134 lines	0 comments	Download
M	dart/site/try/nossl.appcache	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
D	dart/site/try/part.js	View	1 2	1 chunk	+0 lines, -24734 lines	0 comments	Download
D	dart/site/try/try-dart-screenshot.png	View	1 2	Binary file		0 comments	Download
D	dart/site/try/update_howto.txt	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/126003002/diff/50002/dart/site/try/create_manifest.sh File dart/site/try/create_manifest.sh (right): https://codereview.chromium.org/126003002/diff/50002/dart/site/try/create_manifest.sh#newcode2 dart/site/try/create_manifest.sh:2: # Copyright (c) 2013, the Dart project authors. ...

6 years, 11 months ago (2014-01-08 14:23:25 UTC) #2

ahe

Thank you, Kasper! https://codereview.chromium.org/126003002/diff/50002/dart/site/try/create_manifest.sh File dart/site/try/create_manifest.sh (right): https://codereview.chromium.org/126003002/diff/50002/dart/site/try/create_manifest.sh#newcode2 dart/site/try/create_manifest.sh:2: # Copyright (c) 2013, the Dart ...

6 years, 11 months ago (2014-01-09 15:04:09 UTC) #3

ahe

6 years, 11 months ago (2014-01-09 15:04:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r31660 (presubmit successful).

Expand Messages | Collapse Messages