Issue 12600033: pkg/logging: removed deprecated 'on' API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12600033: pkg/logging: removed deprecated 'on' API (Closed)

Created:
7 years, 9 months ago by kevmoo-old

Modified:
7 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang), gram

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

pkg/logging: removed deprecated 'on' API Committed: https://code.google.com/p/dart/source/detail?r=20574

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -405 lines)			Patch
M	pkg/logging/lib/logging.dart	View	5 chunks	+0 lines, -61 lines	0 comments	Download
M	pkg/logging/pubspec.yaml	View	1 chunk	+2 lines, -8 lines	0 comments	Download
D	pkg/logging/test/logging_deprecated_test.dart	View	1 chunk	+0 lines, -336 lines	0 comments	Download

Total messages: 5 (0 generated)

gram

Looks okay to me but please wait for an lgtm from Siggi for this one.

7 years, 9 months ago (2013-03-25 18:40:43 UTC) #2

Siggi Cherem (dart-lang)

On 2013/03/27 19:07:41, Siggi Cherem (dart-lang) wrote: > lgtm ... and thanks for following up ...

7 years, 9 months ago (2013-03-27 19:08:05 UTC) #4

kevmoo-old

7 years, 9 months ago (2013-03-27 20:36:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r20574 (presubmit successful).