Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 12600012: Add a new, separate block entry instruction for catch-blocks. (Closed)

Created:
7 years, 9 months ago by Florian Schneider
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add a new, separate block entry instruction for catch-blocks. This is a preparation CL for supporting try-catch in optimized code. Until now, we used normal TargetEntryInstr for catch blocks. This meant carrying around handler_types_ and catch_try_index_ for blocks that are not catch blocks which is not needed. For now, CatchBlockEntry behaves the same as TargetBlockEntry except for the additional members needed for catch blocks. Committed: https://code.google.com/p/dart/source/detail?r=19864

Patch Set 1 #

Patch Set 2 : fixed IL printer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -33 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 1 chunk +9 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language.h View 7 chunks +46 lines, -17 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +22 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 9 months ago (2013-03-11 17:23:39 UTC) #1
Vyacheslav Egorov (Google)
lgtm
7 years, 9 months ago (2013-03-12 13:10:47 UTC) #2
Florian Schneider
7 years, 9 months ago (2013-03-12 13:51:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19864 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698