Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1259813003: Fix #23871: identical on consts should be always const (Closed)

Created:
5 years, 4 months ago by srdjan
Modified:
5 years, 4 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix #23871: identical on consts should be always const BUG=23871 R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/fafbe30eb0d7f62a5442f3fcfeb7c6c40a55b5c7

Patch Set 1 #

Patch Set 2 : ns #

Patch Set 3 : fix #

Total comments: 2

Patch Set 4 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M runtime/vm/ast.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M tests/language/const_syntax_test.dart View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
srdjan
5 years, 4 months ago (2015-07-28 17:29:54 UTC) #2
srdjan
PTAL
5 years, 4 months ago (2015-07-28 17:55:14 UTC) #3
hausner
lgtm w/ comment https://codereview.chromium.org/1259813003/diff/30001/runtime/vm/ast.cc File runtime/vm/ast.cc (right): https://codereview.chromium.org/1259813003/diff/30001/runtime/vm/ast.cc#newcode246 runtime/vm/ast.cc:246: case Token::kNE_STRICT: // identical(a, b) is ...
5 years, 4 months ago (2015-07-28 18:01:58 UTC) #4
srdjan
https://codereview.chromium.org/1259813003/diff/30001/runtime/vm/ast.cc File runtime/vm/ast.cc (right): https://codereview.chromium.org/1259813003/diff/30001/runtime/vm/ast.cc#newcode246 runtime/vm/ast.cc:246: case Token::kNE_STRICT: On 2015/07/28 18:01:58, hausner wrote: > // ...
5 years, 4 months ago (2015-07-28 18:36:08 UTC) #5
srdjan
5 years, 4 months ago (2015-07-28 18:37:36 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:50001) manually as
fafbe30eb0d7f62a5442f3fcfeb7c6c40a55b5c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698