Issue 12598008: pkg/unittest: fixed deprecations in alt configs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12598008: pkg/unittest: fixed deprecations in alt configs (Closed)

Created:
7 years, 9 months ago by kevmoo-old

Modified:
7 years, 9 months ago

Reviewers:
gram

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/unittest: fixed deprecations in alt configs specifically compact_vm_config, html_layout_config, interactive_html_config No tests exist for these. Verified interactive_html_config is no longer broken All are now 'green' under editor analysis Committed: https://code.google.com/p/dart/source/detail?r=19908

Patch Set 1 #

Patch Set 2 : variable name tweaks #

Total comments: 1

Patch Set 3 : last nite from gram #

Patch Set 4 : any changes? #

Patch Set 5 : spelling and copyright year #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -56 lines)			Patch
M	pkg/unittest/lib/compact_vm_config.dart	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/unittest/lib/html_layout_config.dart	View	1 2 3 4	12 chunks	+27 lines, -26 lines	0 comments	Download
M	pkg/unittest/lib/interactive_html_config.dart	View	1 2 3 4	14 chunks	+25 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gram

LGTM, just one nit. https://codereview.chromium.org/12598008/diff/3001/pkg/unittest/lib/interactive_html_config.dart File pkg/unittest/lib/interactive_html_config.dart (right): https://codereview.chromium.org/12598008/diff/3001/pkg/unittest/lib/interactive_html_config.dart#newcode61 pkg/unittest/lib/interactive_html_config.dart:61: assert(_errorSubscription == null); This assert ...

7 years, 9 months ago (2013-03-12 22:44:46 UTC) #2

kevmoo-old

7 years, 9 months ago (2013-03-13 02:03:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r19908 (presubmit successful).

Expand Messages | Collapse Messages