Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1259713005: Save a few register moves in function prolog on arm64 by using the same pattern (Closed)

Created:
5 years, 4 months ago by regis
Modified:
5 years, 4 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Save a few register moves in function prolog on arm64 by using the same pattern as on x64 dealing with two pool pointers. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/0778c11ffb861a70af12d7c1c7a50eda4e98a26f

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -15 lines) Patch
M runtime/vm/assembler_arm64.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 3 chunks +16 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 1 chunk +2 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
5 years, 4 months ago (2015-07-31 00:17:32 UTC) #2
zra
lgtm https://codereview.chromium.org/1259713005/diff/1/runtime/vm/assembler_arm64.h File runtime/vm/assembler_arm64.h (right): https://codereview.chromium.org/1259713005/diff/1/runtime/vm/assembler_arm64.h#newcode1308 runtime/vm/assembler_arm64.h:1308: void LoadFunctionFromNewPool(Register dst, Maybe CalleePool https://codereview.chromium.org/1259713005/diff/1/runtime/vm/assembler_arm64.h#newcode1309 runtime/vm/assembler_arm64.h:1309: const ...
5 years, 4 months ago (2015-07-31 17:40:24 UTC) #3
regis
Thanks! https://codereview.chromium.org/1259713005/diff/1/runtime/vm/assembler_arm64.h File runtime/vm/assembler_arm64.h (right): https://codereview.chromium.org/1259713005/diff/1/runtime/vm/assembler_arm64.h#newcode1308 runtime/vm/assembler_arm64.h:1308: void LoadFunctionFromNewPool(Register dst, On 2015/07/31 17:40:24, zra wrote: ...
5 years, 4 months ago (2015-07-31 19:43:03 UTC) #4
regis
5 years, 4 months ago (2015-07-31 19:48:53 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0778c11ffb861a70af12d7c1c7a50eda4e98a26f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698