Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 12596004: Replaced Element.append with Node.appendChild (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -83 lines) Patch
M samples/third_party/dromaeo/tests/dom-modify-html.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/dromaeo/tests/dom-query-html.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/dromaeo/tests/dom-traverse-html.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 11 chunks +12 lines, -27 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 10 chunks +11 lines, -26 lines 0 comments Download
M tests/html/node_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 3 chunks +3 lines, -11 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 4 chunks +3 lines, -10 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 9 months ago (2013-03-08 23:34:41 UTC) #1
Jacob
lgtm
7 years, 9 months ago (2013-03-09 04:52:41 UTC) #2
blois
7 years, 9 months ago (2013-03-11 16:40:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19804 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698