Issue 12595004: Fix handling to responses to HEAD requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12595004: Fix handling to responses to HEAD requests (Closed)

Created:
7 years, 9 months ago by Søren Gjesse

Modified:
7 years, 9 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix handling to responses to HEAD requests The HTTP parser did not handle requests to HEAD requests if chunked transfer encoding is used by in the response. The check for chunked encoding was done before checking for a response to a head request. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19612

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -30 lines)			Patch
M	sdk/lib/io/http_impl.dart	View	1	6 chunks	+14 lines, -17 lines	0 comments	Download
M	sdk/lib/io/http_parser.dart	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	tests/standalone/io/http_head_test.dart	View		3 chunks	+28 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, nice find. From a bug? https://codereview.chromium.org/12595004/diff/1/sdk/lib/io/http_parser.dart File sdk/lib/io/http_parser.dart (right): https://codereview.chromium.org/12595004/diff/1/sdk/lib/io/http_parser.dart#newcode570 sdk/lib/io/http_parser.dart:570: (_messageType == _MessageType.RESPONSE ...

7 years, 9 months ago (2013-03-07 09:38:59 UTC) #2

Søren Gjesse

No bug report - something I found while making other updates. https://codereview.chromium.org/12595004/diff/1/sdk/lib/io/http_parser.dart File sdk/lib/io/http_parser.dart (right): ...

7 years, 9 months ago (2013-03-07 11:42:10 UTC) #3

Søren Gjesse

7 years, 9 months ago (2013-03-07 11:44:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r19612 (presubmit successful).

Expand Messages | Collapse Messages