Issue 12594027: Support pure isolate timers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12594027: Support pure isolate timers. (Closed)

Created:
7 years, 9 months ago by Anton Muhin

Modified:
7 years, 9 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, podivilov

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support pure isolate timers. R=vsm@google.com BUG=4997 Committed: https://code.google.com/p/dart/source/detail?r=20608

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -0 lines)			Patch
	M	tools/dom/src/Timer.dart	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

LGTM Nice use of spawnDomFunction! https://codereview.chromium.org/12594027/diff/1/tools/dom/src/Timer.dart File tools/dom/src/Timer.dart (right): https://codereview.chromium.org/12594027/diff/1/tools/dom/src/Timer.dart#newcode44 tools/dom/src/Timer.dart:44: assert(replyTo == _HELPER_ISOLATE); Is ...

7 years, 9 months ago (2013-03-27 14:17:35 UTC) #2

Anton Muhin

https://codereview.chromium.org/12594027/diff/1/tools/dom/src/Timer.dart File tools/dom/src/Timer.dart (right): https://codereview.chromium.org/12594027/diff/1/tools/dom/src/Timer.dart#newcode44 tools/dom/src/Timer.dart:44: assert(replyTo == _HELPER_ISOLATE); On 2013/03/27 14:17:36, vsm wrote: > ...

7 years, 9 months ago (2013-03-27 14:32:19 UTC) #3

Anton Muhin

7 years, 9 months ago (2013-03-28 12:16:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20608 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12594027: Support pure isolate timers. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages