Issue 12594013: Fix 9347, always send ExternalTypedData objects as TypedData objects when

Issue 12594013: Fix 9347, always send ExternalTypedData objects as TypedData objects when (Closed)

Created:
7 years, 9 months ago by siva

Modified:
7 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix 9347, always send ExternalTypedData objects as TypedData objects when sending them across isolates. Committed: https://code.google.com/p/dart/source/detail?r=20426

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -18 lines)			Patch
M	runtime/vm/raw_object_snapshot.cc	View		2 chunks	+19 lines, -18 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/standalone/typed_data_isolate_test.dart	View	1 2	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/12594013/diff/3/tests/standalone/typed_data_isolate_test.dart File tests/standalone/typed_data_isolate_test.dart (right): https://codereview.chromium.org/12594013/diff/3/tests/standalone/typed_data_isolate_test.dart#newcode9 tests/standalone/typed_data_isolate_test.dart:9: print(data); // SIGSEGV happens here. I don't ...

7 years, 9 months ago (2013-03-22 23:10:47 UTC) #3

siva

https://codereview.chromium.org/12594013/diff/3/tests/standalone/typed_data_isolate_test.dart File tests/standalone/typed_data_isolate_test.dart (right): https://codereview.chromium.org/12594013/diff/3/tests/standalone/typed_data_isolate_test.dart#newcode9 tests/standalone/typed_data_isolate_test.dart:9: print(data); // SIGSEGV happens here. On 2013/03/22 23:10:47, Ivan ...

7 years, 9 months ago (2013-03-22 23:24:23 UTC) #4

siva

7 years, 9 months ago (2013-03-22 23:29:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r20426 (presubmit successful).

Expand Messages | Collapse Messages