Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1259243005: Add unit test for CPU profile inline function expansion (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add unit test for CPU profile inline function expansion - Add unit test for CPU profile inline function expansion. - Fix missing frame bug in inline function expansion. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ef11d0545b49274392c003a76d2c858bb25643bb

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -2 lines) Patch
M runtime/vm/profiler_service.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/profiler_service.cc View 1 6 chunks +24 lines, -2 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 2 1 chunk +163 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 4 months ago (2015-07-29 14:57:21 UTC) #2
rmacnak
lgtm
5 years, 4 months ago (2015-07-29 17:20:34 UTC) #3
Cutch
5 years, 4 months ago (2015-07-29 17:21:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
ef11d0545b49274392c003a76d2c858bb25643bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698