Initial tree-shaking for precompilation: only selective compilation, no removal of unused Functions…

Initial tree-shaking for precompilation: only selective compilation, no removal of unused Functions/Classes.

hello world 23.1 -> 8.1 MB heap

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/5ea1f9eb3998d1a38c2e51c642fce881ee4b2ccf

[rmacnak, 2015-07-31 23:56:03]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, srdjan@google.com

[Florian Schneider, 2015-08-04 08:20:01]

lgtm

https://codereview.chromium.org/1259123009/diff/60001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1259123009/diff/60001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:427: // Potential const object. Uninitialized field
will harmlessly do a redudant
*redundant

https://codereview.chromium.org/1259123009/diff/60001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:459: // TODO(rmacnak): Use a proper set.
You could use the one from runtime/vm/hash_map.h, and just use String::Hash as
hash function.

[rmacnak, 2015-08-04 18:34:28]

https://codereview.chromium.org/1259123009/diff/60001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1259123009/diff/60001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:427: // Potential const object. Uninitialized field
will harmlessly do a redudant
On 2015/08/04 08:20:01, Florian Schneider wrote:
> *redundant

Done.

https://codereview.chromium.org/1259123009/diff/60001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:459: // TODO(rmacnak): Use a proper set.
On 2015/08/04 08:20:01, Florian Schneider wrote:
> You could use the one from runtime/vm/hash_map.h, and just use String::Hash as
> hash function.

I'll do that in the next CL.

[rmacnak, 2015-08-04 18:35:41]

Committed patchset #4 (id:60001) manually as
5ea1f9eb3998d1a38c2e51c642fce881ee4b2ccf (presubmit successful).

[srdjan, 2015-08-04 19:28:35]

lgtm