Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1258733004: Include a "jsonrpc" property in all VM service responses. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include a "jsonrpc" property in all VM service responses. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/cf0955a83eb3bf37a8006b204b6dc43a821c1d3b

Patch Set 1 #

Patch Set 2 : changelog update #

Patch Set 3 : add for error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/service/message.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service/vmservice.dart View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
5 years, 4 months ago (2015-07-24 22:43:13 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-07-27 13:56:52 UTC) #3
nweiz
5 years, 4 months ago (2015-07-27 18:10:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
cf0955a83eb3bf37a8006b204b6dc43a821c1d3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698