Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1258723002: Generalize the dependency tracking mechanism used by ContextManager. (Closed)

Created:
5 years, 4 months ago by Paul Berry
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generalize the dependency tracking mechanism used by ContextManager. Previously, we tracked "pub list" dependencies using ContextInfo.packageMapInfo.dependencies, but that mechanism could only be used for folders that resolved packages using "pub list". Other dependencies were tracked ad hoc (such as dependencies on ".packages", or anti-dependencies* on "pubspec.yaml"); others weren't tracked at all (such as dependencies on ".analysis_options"). (*In this context, an "anti-dependency" is a dependency on the fact that a file is absent. E.g. when we decide not to create a separate context for a subfolder, it is in part because that subfolder lacks its own "pubspec.yaml" file.) This CL migrates the "pub list" dependencies to a more general mechanism; future CL's will migrate the other ad hoc dependencies to use the same mechanism. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/641284a263b9802e27f818cc3e44fbf3e96699e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -48 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 15 chunks +86 lines, -48 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 4 months ago (2015-07-24 20:20:56 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-07-24 21:34:01 UTC) #3
Paul Berry
5 years, 4 months ago (2015-07-24 21:52:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
641284a263b9802e27f818cc3e44fbf3e96699e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698