Issue 1258473003: Introduce FolderDisposition class hierarchy for use in ContextManagerCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1258473003: Introduce FolderDisposition class hierarchy for use in ContextManagerCallback. (Closed)

Created:
5 years, 5 months ago by Paul Berry

Modified:
5 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Introduce FolderDisposition class hierarchy for use in ContextManagerCallback. The new class hierarchy encapsulates the packageUriResolver and packages parameters that were previously used in the ContextManagerCallback API. In a future CL, I intend to use it more extensively within ContextManagerImpl in order to make the algorithm for choosing contexts more declarative. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/7fb62213cfe0b905cdac1c8e1d53fd94dd4f0d9c

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+166 lines, -79 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	4 chunks	+9 lines, -20 lines	0 comments	Download
M	pkg/analysis_server/lib/src/context_manager.dart	View	12 chunks	+132 lines, -33 lines	0 comments	Download
M	pkg/analysis_server/test/context_manager_test.dart	View	9 chunks	+25 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

To be landed after https://codereview.chromium.org/1253803002/

5 years, 5 months ago (2015-07-23 23:59:59 UTC) #2

Paul Berry

5 years, 5 months ago (2015-07-24 13:43:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7fb62213cfe0b905cdac1c8e1d53fd94dd4f0d9c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages