Issue 1258343004: Make binary events JSON-RPC 2.0 compliant as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1258343004: Make binary events JSON-RPC 2.0 compliant as well. (Closed)

Created:
5 years, 4 months ago by nweiz

Modified:
5 years, 4 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, rmacnak

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make binary events JSON-RPC 2.0 compliant as well. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/8afd3d67e748b0998a2dc3b7b3b654d296a1f0d0

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -16 lines)			Patch
	M	runtime/vm/service.cc	View		2 chunks	+26 lines, -16 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

turnidge

lgtm There is this weird thing with binary events where we send them over the ...

5 years, 4 months ago (2015-07-29 16:38:08 UTC) #3

Cutch

Committed patchset #1 (id:1) manually as 8afd3d67e748b0998a2dc3b7b3b654d296a1f0d0 (presubmit successful).

5 years, 4 months ago (2015-07-29 17:20:53 UTC) #4

Cutch

5 years, 4 months ago (2015-07-29 17:22:48 UTC) #5

Message was sent while issue was closed.

On 2015/07/29 17:20:53, Cutch wrote:
> Committed patchset #1 (id:1) manually as
> 8afd3d67e748b0998a2dc3b7b3b654d296a1f0d0 (presubmit successful).

I landed this for Natalie so that the VM bots will cycle green sooner.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages