Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1258243002: Expose getter and setter invocations by name, in dart2js 'World'. (Closed)

Created:
5 years, 4 months ago by Anders Johnsen
Modified:
5 years, 4 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Expose getter and setter invocations by name, in dart2js 'World'. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/98772b972658a5b30003f147a3691c42b3097ee3

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M pkg/compiler/lib/src/universe/universe.dart View 1 2 2 chunks +16 lines, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Anders Johnsen
5 years, 4 months ago (2015-07-28 10:38:28 UTC) #2
Anders Johnsen
PTAL
5 years, 4 months ago (2015-07-28 11:09:59 UTC) #3
Johnni Winther
lgtm
5 years, 4 months ago (2015-07-28 11:16:19 UTC) #4
Anders Johnsen
5 years, 4 months ago (2015-07-28 11:17:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
98772b972658a5b30003f147a3691c42b3097ee3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698