Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1257943003: Support JSON-RPC 2.0-compatible VM service events. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, devoncarew
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support JSON-RPC 2.0-compatible VM service events. This adds a parameter to streamListen that will cause it to produce JSON-RPC 2.0-compatible events. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/61ea0618ce6e29cf101bc9c062222f04b97f211a

Patch Set 1 #

Patch Set 2 : cr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -24 lines) Patch
M CHANGELOG.md View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/service_common.dart View 1 2 chunks +7 lines, -6 lines 0 comments Download
M runtime/vm/service.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/service/service.md View 1 3 chunks +21 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nweiz
Note that this follows my original proposal for the JSON-RPC event format; it may need ...
5 years, 4 months ago (2015-07-27 23:36:55 UTC) #2
Cutch
On 2015/07/27 23:36:55, nweiz wrote: > Note that this follows my original proposal for the ...
5 years, 4 months ago (2015-07-27 23:48:12 UTC) #4
nweiz
PTAL I removed backwards incompatibility and changed to Todd's notification format.
5 years, 4 months ago (2015-07-28 00:24:16 UTC) #5
turnidge
lgtm Thank you for this and your other work on the protocol. Much appreciated.
5 years, 4 months ago (2015-07-28 21:20:43 UTC) #6
nweiz
5 years, 4 months ago (2015-07-29 00:17:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
61ea0618ce6e29cf101bc9c062222f04b97f211a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698