Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1257933002: Convert ContextManager to recursively watch analysis roots. (Closed)

Created:
5 years, 4 months ago by Paul Berry
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Convert ContextManager to recursively watch analysis roots. Previously ContextManager watched the contents of each context folder independently; this was redundant in the case where one context folder was nested inside another. Also it led to some race conditions, since we had to examine the contents of a folder in order to determine whether there should be a context associated with it, but we couldn't begin watching those files for that context until after the context was created; this left a small window of time where a change to the files might go unnoticed. Note that a minor functional change is introduced: if "pub list" indicates that the package resolution for a given folder is dependent upon a file outside that folder, we no longer watch that file for changes. This shouldn't be a problem, since in practice "pub list" always lists exactly two files as dependencies, and both of those files are inside the folder (pubspec.yaml and pubspec.lock). R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/f5dab3fd2b82d8459a2677c59ccdf474231cb6f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -123 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 17 chunks +58 lines, -95 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 4 months ago (2015-07-26 22:21:58 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-07-27 00:35:39 UTC) #3
Paul Berry
5 years, 4 months ago (2015-07-27 03:56:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f5dab3fd2b82d8459a2677c59ccdf474231cb6f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698