Issue 1257913002: Improve package root tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1257913002: Improve package root tests. (Closed)

Created:
5 years, 5 months ago by Paul Berry

Modified:
5 years, 5 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Improve package root tests. Partially fixes #23909. Previously, these tests didn't work at all. Now they verify that the FolderDisposition is based on the correct package root, but they don't yet verify that the package map is generated correctly. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/cdfa46faa594c1d382675419716fb3fdbffa3f63

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -68 lines)			Patch
	M	pkg/analysis_server/lib/src/context_manager.dart	View		6 chunks	+24 lines, -6 lines	0 comments	Download
	M	pkg/analysis_server/test/context_manager_test.dart	View		5 chunks	+57 lines, -62 lines	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

5 years, 5 months ago (2015-07-26 22:09:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cdfa46faa594c1d382675419716fb3fdbffa3f63 (presubmit successful).