Issue 12578011: Mark stream_pariodic4 as flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12578011: Mark stream_pariodic4 as flaky. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 9 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark stream_pariodic4 as flaky. When running on a machine with heavy load, even 100ms isn't always enough for a 5ms period timer. Committed: https://code.google.com/p/dart/source/detail?r=20371

Patch Set 2 : Add issue number. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/lib/lib.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/12578011/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/12578011/diff/1/tests/lib/lib.status#newcode5 tests/lib/lib.status:5: async/stream_periodic4_test: Pass, Fail # Some times 100 ms ...

7 years, 9 months ago (2013-03-22 10:08:09 UTC) #2

Lasse Reichstein Nielsen

https://codereview.chromium.org/12578011/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/12578011/diff/1/tests/lib/lib.status#newcode5 tests/lib/lib.status:5: async/stream_periodic4_test: Pass, Fail # Some times 100 ms is ...

7 years, 9 months ago (2013-03-22 10:10:26 UTC) #3

Lasse Reichstein Nielsen

7 years, 9 months ago (2013-03-22 10:16:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20371 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12578011: Mark stream_pariodic4 as flaky. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add issue number. #

Messages