Issue 12578009: - Canonicalize types, type_arguments only when the object is marked as being from the core librarie…

Issue 12578009: - Canonicalize types, type_arguments only when the object is marked as being from the core librarie… (Closed)

Created:
7 years, 9 months ago by siva

Modified:
7 years, 9 months ago

Reviewers:
regis, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Canonicalize types, type_arguments only when the object is marked as being from the core libraries. - adjust the snapshot write buffer growth policy - turn off the heap growth rate adjustments when reading from a snapshot. Committed: https://code.google.com/p/dart/source/detail?r=20423

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 10

Patch Set 4 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -40 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_message.h	View	1 2 3	1 chunk	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/datastream.h	View	1 2 3	3 chunks	+12 lines, -8 lines	0 comments	Download
M	runtime/vm/heap.h	View	1 2 3	2 chunks	+14 lines, -1 line	0 comments	Download
M	runtime/vm/heap.cc	View	1 2 3	2 chunks	+21 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/pages.h	View	1 2 3	2 chunks	+11 lines, -4 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1 2 3	5 chunks	+46 lines, -5 lines	0 comments	Download
M	runtime/vm/snapshot.h	View	1 2 3	5 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments about comments. -Ivan https://chromiumcodereview.appspot.com/12578009/diff/18001/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://chromiumcodereview.appspot.com/12578009/diff/18001/runtime/vm/raw_object_snapshot.cc#newcode208 runtime/vm/raw_object_snapshot.cc:208: if (RawObject::IsCanonical(tags)) { ...

7 years, 9 months ago (2013-03-22 21:17:22 UTC) #3

siva

https://chromiumcodereview.appspot.com/12578009/diff/18001/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://chromiumcodereview.appspot.com/12578009/diff/18001/runtime/vm/raw_object_snapshot.cc#newcode208 runtime/vm/raw_object_snapshot.cc:208: if (RawObject::IsCanonical(tags)) { Added a comment detailing each case ...

7 years, 9 months ago (2013-03-22 22:33:19 UTC) #4

siva

7 years, 9 months ago (2013-03-22 22:43:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r20423 (presubmit successful).

Expand Messages | Collapse Messages