Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1257513002: dart2js: fix crash when annotations have syntax errors (fix #23983) (Closed)

Created:
5 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 4 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -6 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +2 lines, -0 lines 2 comments Download
M pkg/compiler/lib/src/scanner/listener.dart View 1 chunk +11 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/compiler/dart2js_extra/invalid_annotation2_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A tests/compiler/dart2js_extra/invalid_annotation_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Siggi Cherem (dart-lang)
5 years, 5 months ago (2015-07-23 22:56:42 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/1257513002/diff/20001/pkg/compiler/lib/src/compile_time_constants.dart File pkg/compiler/lib/src/compile_time_constants.dart (right): https://codereview.chromium.org/1257513002/diff/20001/pkg/compiler/lib/src/compile_time_constants.dart#newcode339 pkg/compiler/lib/src/compile_time_constants.dart:339: // TODO(johnniwinter): should there be a visitErrorNode? 'johnniwinter' ...
5 years, 4 months ago (2015-07-27 07:57:05 UTC) #4
Siggi Cherem (dart-lang)
Committed patchset #1 (id:20001) manually as e09981a6d0674293d3c15062f7e2fa9f50cd9b4b (presubmit successful).
5 years, 4 months ago (2015-07-27 16:20:56 UTC) #5
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-07-27 16:26:44 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1257513002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/1257513002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compile_time_constants.dart:339: // TODO(johnniwinter):
should there be a visitErrorNode?
On 2015/07/27 07:57:05, Johnni Winther wrote:
> 'johnniwinter' -> 'johnniwinther' (but kudos for getting 'johnni' right :)

Oh thanks for letting me know :) 

I forgot to include it when I submitted (I got confused and thought it was
another CL), but I sent a follow up change to fix it.

Powered by Google App Engine
This is Rietveld 408576698