Issue 1256833003: Add Timeout.none.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1256833003: Add Timeout.none. (Closed)

Created:
5 years, 4 months ago by nweiz

Modified:
5 years, 4 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -33 lines)			Patch
M	CHANGELOG.md	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/src/backend/invoker.dart	View	1 2 3	4 chunks	+13 lines, -3 lines	0 comments	Download
M	lib/src/backend/metadata.dart	View	1 2	3 chunks	+22 lines, -10 lines	0 comments	Download
M	lib/src/frontend/timeout.dart	View		3 chunks	+19 lines, -4 lines	0 comments	Download
M	lib/src/runner/parse_metadata.dart	View		4 chunks	+41 lines, -16 lines	0 comments	Download
M	test/backend/invoker_test.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	test/runner/parse_metadata_test.dart	View		2 chunks	+15 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

kevmoo

code LGTM, but I'm seeing three failures in test/backend/invoker_test.dart - "Bad state: Can't add or ...

5 years, 4 months ago (2015-07-28 02:56:43 UTC) #2

nweiz

5 years, 4 months ago (2015-07-28 20:18:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
cd8fd686c0c980192a9ac29f2e6da38c35e9897f (presubmit successful).