Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 12568007: Translate raw strings to regular strings during source code generation. This should hopefully avoid… (Closed)

Created:
7 years, 9 months ago by siva
Modified:
7 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Translate raw strings to regular strings during source code generation. This should hopefully avoid issues with deciding when to escape special characters and when not to. Committed: https://code.google.com/p/dart/source/detail?r=20248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -51 lines) Patch
M runtime/vm/object.h View 3 chunks +3 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 8 chunks +15 lines, -46 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 9 months ago (2013-03-19 17:05:11 UTC) #1
Ivan Posva
LGTM -ip
7 years, 9 months ago (2013-03-19 18:36:03 UTC) #2
siva
7 years, 9 months ago (2013-03-19 21:32:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20248 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698