Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1256763004: Fix issue #23914: do not attempt to make an already immutable array immutable (Closed)

Created:
5 years, 4 months ago by srdjan
Modified:
5 years, 4 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix issue #23914: do not attempt to make an already immutable array immutable BUG=23914 R=asiva@google.com, iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/9dbb6d488f6f594dfa073afe506bcc253ded9def

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M runtime/vm/object.cc View 3 chunks +3 lines, -2 lines 0 comments Download
A + tests/language/issue_23914_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
srdjan
5 years, 4 months ago (2015-07-27 23:34:23 UTC) #2
Ivan Posva
LGTM -ip
5 years, 4 months ago (2015-07-27 23:38:11 UTC) #4
siva
lgtm
5 years, 4 months ago (2015-07-27 23:39:02 UTC) #5
srdjan
5 years, 4 months ago (2015-07-27 23:44:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9dbb6d488f6f594dfa073afe506bcc253ded9def (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698