Issue 1256023003: Use a "jsonrpc" field rather than "json-rpc" in the VM service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1256023003: Use a "jsonrpc" field rather than "json-rpc" in the VM service. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use a "jsonrpc" field rather than "json-rpc" in the VM service. This matches the JSON-RPC 2.0 spec: http://www.jsonrpc.org/specification#response_object While this is technically a breaking change, it seems very unlikely that any consumers were validating this form of the parameter. The documentation was already inconsistent about whether it was hyphenated, and the only code likely to be using would be written against the JSON-RPC 2.0 spec itself, and would reject the old format anyway. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/a2fd2023140f9d2a54e1593b16645aefb41903c7

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	runtime/vm/json_stream.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/service/service.md	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/service_test.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

nweiz

5 years, 5 months ago (2015-07-24 20:29:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a2fd2023140f9d2a54e1593b16645aefb41903c7 (presubmit successful).