Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1255953004: better completions in switch statements (Closed)

Created:
5 years, 4 months ago by danrubel
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/services/completion/optype.dart View 2 chunks +15 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +29 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +56 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 4 months ago (2015-08-03 13:24:41 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-03 13:55:32 UTC) #3
danrubel
5 years, 4 months ago (2015-08-03 21:06:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fde3b1b335b2675493b469f98a9da4abb9597844 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698