Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 12557002: Fixing node_test on IE10. (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing node_test on IE10. Previously these tests were not in a group and were getting skipped, but when I fixed that this test started failing. It appears that IE10 returns false for Node.contains when checking other nodes. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tests/html/node_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 9 months ago (2013-03-07 01:16:31 UTC) #1
Emily Fortuna
Bug 8968 created to make a polyfill. lgtm.
7 years, 9 months ago (2013-03-07 01:19:28 UTC) #2
blois
7 years, 9 months ago (2013-03-07 01:23:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19594 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698