Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 12555005: dart:io | Revert addition of Link class, because it conflicts with a Link class in dart2js. (Closed)

Created:
7 years, 9 months ago by Bill Hesse
Modified:
7 years, 9 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Revert addition of Link class, because it conflicts with a Link class in dart2js. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -333 lines) Patch
M runtime/bin/builtin_natives.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/file.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/file.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M runtime/bin/file_android.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/bin/file_linux.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/bin/file_patch.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/bin/file_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/io_patch.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/io/file.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/io/io.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/io/iolib_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D sdk/lib/io/link.dart View 1 chunk +0 lines, -259 lines 0 comments Download
M tests/standalone/io/file_system_links_test.dart View 8 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
Reverts commits r19775, r19774, and r19772.
7 years, 9 months ago (2013-03-11 11:52:41 UTC) #1
Mads Ager (google)
lgtm
7 years, 9 months ago (2013-03-11 11:54:35 UTC) #2
Bill Hesse
7 years, 9 months ago (2013-03-11 12:00:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19777.

Powered by Google App Engine
This is Rietveld 408576698