Simplify base64 streaming decoder, drop decoding check.

Simplify base64 streaming decoder, drop decoding check.

BUG=
R=sgjesse@google.com

Committed: https://github.com/dart-lang/crypto/commit/dd0ff8b95269b11f7bd925d2f58e5e938c1f03fc

[Bill Hesse, 2015-08-04 16:33:33]

whesse@google.com changed reviewers:
+ sgjesse@google.com

[Bill Hesse, 2015-08-04 16:33:33]

This will turn the package bot green for this package again.

The check for consistency while decoding is removed, since
discussion of the previous CL said it should not auto-detect,
and it could be added back in a better implementation later.

https://codereview.chromium.org/1255293010/diff/1/lib/src/base64.dart
File lib/src/base64.dart (left):

https://codereview.chromium.org/1255293010/diff/1/lib/src/base64.dart#oldcode455
lib/src/base64.dart:455: _outSink.add(_buffer + _PAD);
This line was wrong, should have been .add(_decoder.convert(buffer + PAD)).

[Søren Gjesse, 2015-08-05 07:18:33]

lgtm

https://codereview.chromium.org/1255293010/diff/1/lib/src/base64.dart
File lib/src/base64.dart (left):

https://codereview.chromium.org/1255293010/diff/1/lib/src/base64.dart#oldcode34
lib/src/base64.dart:34: const List<String> _URL_UNSAFE_CHARACTERS = const ['-',
'_'];
Remove these two constants as well.

https://codereview.chromium.org/1255293010/diff/1/test/base64_test.dart
File test/base64_test.dart (right):

https://codereview.chromium.org/1255293010/diff/1/test/base64_test.dart#newco...
test/base64_test.dart:83: const _INCONSISTENT_SAFE_RESULT = 'A+_x';
Remove this constant and the next as well.

[Bill Hesse, 2015-08-05 07:48:30]

Committed patchset #1 (id:1) manually as
dd0ff8b95269b11f7bd925d2f58e5e938c1f03fc (presubmit successful).