|
|
Fix analyzer interpretation of 'ClassName?.staticMember'.
Previously, trying to access a static member of a class using '?.' was
not allowed. But the spec was changed in
b11670f89924c1961be8f93d00848c7fa9887f99 so that
'ClassName?.staticMember' is now equivalent to
'ClassName.staticMember'.
This CL updates analyzer to follow the spec, and updates the tests in
"tests/language" accordingly. VM and dart2js still need fixing
(see #23794 and #23795).
Fixes #23464.
R=scheglov@google.com
Committed: https://github.com/dart-lang/sdk/commit/0e98c581905bf0c5885c5b2dc4872921e95a7db0
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+275 lines, -88 lines) |
Patch |
 |
M |
pkg/analyzer/lib/src/generated/element_resolver.dart
|
View
|
|
6 chunks |
+8 lines, -11 lines |
0 comments
|
Download
|
|
M |
pkg/analyzer/lib/src/generated/error_verifier.dart
|
View
|
|
3 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
|
M |
pkg/analyzer/test/generated/non_error_resolver_test.dart
|
View
|
|
4 chunks |
+28 lines, -11 lines |
0 comments
|
Download
|
|
M |
pkg/analyzer/test/generated/static_type_warning_code_test.dart
|
View
|
|
3 chunks |
+10 lines, -27 lines |
0 comments
|
Download
|
|
M |
tests/language/conditional_access_helper.dart
|
View
|
|
1 chunk |
+22 lines, -2 lines |
0 comments
|
Download
|
|
M |
tests/language/conditional_method_invocation_test.dart
|
View
|
|
3 chunks |
+14 lines, -9 lines |
0 comments
|
Download
|
|
M |
tests/language/conditional_property_access_test.dart
|
View
|
|
3 chunks |
+13 lines, -9 lines |
0 comments
|
Download
|
|
M |
tests/language/conditional_property_assignment_test.dart
|
View
|
|
4 chunks |
+20 lines, -11 lines |
0 comments
|
Download
|
|
M |
tests/language/conditional_property_increment_decrement_test.dart
|
View
|
|
2 chunks |
+36 lines, -2 lines |
0 comments
|
Download
|
|
M |
tests/language/if_null_assignment_behavior_test.dart
|
View
|
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
|
M |
tests/language/language.status
|
View
|
|
1 chunk |
+55 lines, -0 lines |
0 comments
|
Download
|
|
M |
tests/language/language_dart2js.status
|
View
|
|
1 chunk |
+56 lines, -0 lines |
0 comments
|
Download
|
|
M |
tests/language/nullaware_opt_test.dart
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
Total messages: 4 (1 generated)
|
Chromium Code Reviews
Issue
1255293005:
Fix analyzer interpretation of 'ClassName?.staticMember'. (Closed)
