Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 125513004: Fix setRange_4_test (Closed)

Created:
6 years, 11 months ago by sra1
Modified:
6 years, 11 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tests/lib/lib.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/typed_data/setRange_4_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
setRange_4_test was relying on Int8List implementing ByteBuffer. Typed data should not implement ByteBuffer. This is ...
6 years, 11 months ago (2014-01-07 02:14:56 UTC) #1
sra1
6 years, 11 months ago (2014-01-07 19:32:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r31565 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698