Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1255003004: Implement patch records to patch canonical objects. (Closed)

Created:
5 years, 5 months ago by siva
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for bug 21079 Implement patch records to patch canonical objects. BUG=21079 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/325f40d9db09203b7a72023816447ef6177a7d9f

Patch Set 1 #

Patch Set 2 : self-code-review #

Patch Set 3 : merge-to-tot #

Patch Set 4 : add-test #

Patch Set 5 : merged-to-tot #

Total comments: 3

Patch Set 6 : address-code-review #

Total comments: 2

Patch Set 7 : address-code-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -77 lines) Patch
M runtime/vm/object.h View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 3 4 5 16 chunks +51 lines, -50 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 3 4 5 4 chunks +57 lines, -9 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 3 4 5 9 chunks +109 lines, -18 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 2 3 4 5 6 1 chunk +112 lines, -0 lines 0 comments Download
A tests/language/issue21079_test.dart View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download
M tests/language/issue23244_test.dart View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
siva
5 years, 4 months ago (2015-07-27 21:15:21 UTC) #2
rmacnak
lgtm w/c https://codereview.chromium.org/1255003004/diff/80001/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://codereview.chromium.org/1255003004/diff/80001/runtime/vm/snapshot.cc#newcode1156 runtime/vm/snapshot.cc:1156: if (ref.defer_canonicalization()) { Redundant with check in ...
5 years, 4 months ago (2015-07-28 22:43:22 UTC) #3
siva
Added a unit test. PTAL. https://codereview.chromium.org/1255003004/diff/80001/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://codereview.chromium.org/1255003004/diff/80001/runtime/vm/snapshot.cc#newcode1156 runtime/vm/snapshot.cc:1156: if (ref.defer_canonicalization()) { On ...
5 years, 4 months ago (2015-07-30 02:03:48 UTC) #4
rmacnak
lgtm w/c https://codereview.chromium.org/1255003004/diff/100001/runtime/vm/snapshot_test.cc File runtime/vm/snapshot_test.cc (right): https://codereview.chromium.org/1255003004/diff/100001/runtime/vm/snapshot_test.cc#newcode1130 runtime/vm/snapshot_test.cc:1130: free(script_snapshot); missing free(full_snapshot)
5 years, 4 months ago (2015-07-30 17:07:41 UTC) #5
siva
https://codereview.chromium.org/1255003004/diff/100001/runtime/vm/snapshot_test.cc File runtime/vm/snapshot_test.cc (right): https://codereview.chromium.org/1255003004/diff/100001/runtime/vm/snapshot_test.cc#newcode1130 runtime/vm/snapshot_test.cc:1130: free(script_snapshot); On 2015/07/30 17:07:41, rmacnak wrote: > missing free(full_snapshot) ...
5 years, 4 months ago (2015-07-30 17:17:07 UTC) #6
siva
5 years, 4 months ago (2015-07-30 17:24:18 UTC) #7
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
325f40d9db09203b7a72023816447ef6177a7d9f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698