Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1254933003: Modify DEP 34 language tests in preparation for adding analyzer support. (Closed)

Created:
5 years, 4 months ago by Paul Berry
Modified:
5 years, 4 months ago
Reviewers:
regis, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Modify DEP 34 language tests in preparation for adding analyzer support. Both of these tests used "VMOptions" to enable the new behavior. They need to use "SharedOptions" so that the new behavior is also enabled in dart2js and analyzer. Also, since mixin_super_bound2_test verifies that the appropriate errors are thrown at runtime when type bounds are incorrect, it's going to have a static warning when run through the analyzer (once the analyzer supports DEP 34). In order to prevent this from leading to a buildbot failure, we need to change the test into a multitest: - mixin_super_bound2_test/01 reproduces the previous behavior of the test, throwing the appropriate errors at runtime and generating a static warning when analyzed. - mixin_super_bound2_test/none lacks the incorrect type bounds, so it doesn't produce and runtime errors or static warnings. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/a8b9e9959ced4d68f689cdeabd6f7c174ffd0374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M tests/language/mixin_super_bound2_test.dart View 3 chunks +17 lines, -6 lines 0 comments Download
M tests/language/mixin_super_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
5 years, 4 months ago (2015-07-29 15:47:50 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-07-29 15:53:39 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as a8b9e9959ced4d68f689cdeabd6f7c174ffd0374 (presubmit successful).
5 years, 4 months ago (2015-07-29 15:59:05 UTC) #4
regis
5 years, 4 months ago (2015-07-29 16:02:58 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698