Issue 12549025: Narrowing attribute maps to only accept strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12549025: Narrowing attribute maps to only accept strings. (Closed)

Created:
7 years, 9 months ago by blois

Modified:
7 years, 9 months ago

Reviewers:
Jennifer Messerly, Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Narrowing attribute maps to only accept strings. Previously they could accept any value and would convert to a string, but it's not incredibly useful and potentially confusing. BUG=8191 Committed: https://code.google.com/p/dart/source/detail?r=20352

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -29 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/html/element_test.dart	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	tests/html/instance_of_test.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	tools/dom/src/AttributeMap.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 9 months ago (2013-03-21 21:08:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20352 (presubmit successful).

Expand Messages | Collapse Messages