Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 12549007: Stop handling VM messages if the isolate has an uncaught (sticky) (Closed)

Created:
7 years, 9 months ago by Tom Ball
Modified:
7 years, 9 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Stop handling VM messages if the isolate has an uncaught (sticky) exception from the previous message. The Dartium engineers requested it because they were seeing confusing stack traces. BUG: 7515 Committed: https://code.google.com/p/dart/source/detail?r=19652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Ball
7 years, 9 months ago (2013-03-06 21:31:04 UTC) #1
siva
lgtm
7 years, 9 months ago (2013-03-07 02:40:44 UTC) #2
Tom Ball
7 years, 9 months ago (2013-03-07 21:00:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698