Issue 1254833005: Update gyp to 6ee91ad8659871916f9aa840d42e1513befdf638

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1254833005: Update gyp to 6ee91ad8659871916f9aa840d42e1513befdf638 (Closed)

Created:
5 years, 4 months ago by ricow1

Modified:
5 years, 4 months ago

Reviewers:
ahe, Bill Hesse, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Update gyp to 6ee91ad8659871916f9aa840d42e1513befdf638 We have not updated gyp in years, I assume that is because we did not want to default to vs 2013 project files. We will now start requiring vs 2013 (for boringssl) - so this updates us to TOT. R=ahe@google.com, iposva@google.com, whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3487bf8b36eb0cddbb85001c6934287f5acb2186

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	DEPS	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

ricow1

Ivan/Peter: do you have any concerns here (I am doing this since Bill is out ...

5 years, 4 months ago (2015-07-30 12:40:53 UTC) #1

ahe

Rico, I've been thinking that we need to update GYP for a while since Subversion ...

5 years, 4 months ago (2015-07-30 13:09:32 UTC) #2

ricow1

Committed patchset #1 (id:1) manually as 3487bf8b36eb0cddbb85001c6934287f5acb2186 (presubmit successful).

5 years, 4 months ago (2015-07-30 13:19:08 UTC) #4

Ivan Posva

5 years, 4 months ago (2015-07-30 13:19:22 UTC) #5

Message was sent while issue was closed.

On 2015/07/30 13:18:30, Ivan Posva wrote:
> LGTM
> 
> -Ivan

And Thanks for rolling this forward after quite some time.

-Ivan