Update context2d.arc to take optional anticlockwise parameter

Update context2d.arc to take optional anticlockwise parameter

Committed: https://code.google.com/p/dart/source/detail?r=19707

[Andrei Mouravski, 2013-03-08 00:34:59]

I have some documentation for arc, but I'll go ahead and put it into another CL.

[blois, 2013-03-08 01:54:50]

https://codereview.chromium.org/12548010/diff/1/tests/html/canvasrenderingcon...
File tests/html/canvasrenderingcontext2d_test.dart (right):

https://codereview.chromium.org/12548010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:12: checkPixel(List<int> pixel,
List<int> expected, {ignoreAlpha: false}) {
I don't see ignoreAlpha being used anywhere.

https://codereview.chromium.org/12548010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:16: // We might not care about the
exact alpha value (because of aliasing.)
Alpha will impact the other channels as well. We should test far enough away
from edges to avoid aliasing issues (use wide strokes).

https://codereview.chromium.org/12548010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:62: for (int i = 0; i <
data.length; i++) {
data.join(', ')?

https://codereview.chromium.org/12548010/diff/1/tools/dom/idl/dart/dart.idl
File tools/dom/idl/dart/dart.idl (right):

https://codereview.chromium.org/12548010/diff/1/tools/dom/idl/dart/dart.idl#n...
tools/dom/idl/dart/dart.idl:142: [Suppressed] any
arc([Optional=DefaultIsUndefined] float x, [Optional=DefaultIsUndefined] float
y, [Optional=DefaultIsUndefined] float radius, [Optional=DefaultIsUndefined]
float startAngle, [Optional=DefaultIsUndefined] float endAngle, boolean
anticlockwise);
I believe you can remove the DefaultIsUndefined portion.

[Andrei Mouravski, 2013-03-08 08:11:25]

PTAL

https://codereview.chromium.org/12548010/diff/1/tests/html/canvasrenderingcon...
File tests/html/canvasrenderingcontext2d_test.dart (right):

https://codereview.chromium.org/12548010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:12: checkPixel(List<int> pixel,
List<int> expected, {ignoreAlpha: false}) {
On 2013/03/08 01:54:50, blois wrote:
> I don't see ignoreAlpha being used anywhere.

Done.

https://codereview.chromium.org/12548010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:16: // We might not care about the
exact alpha value (because of aliasing.)
On 2013/03/08 01:54:50, blois wrote:
> Alpha will impact the other channels as well. We should test far enough away
> from edges to avoid aliasing issues (use wide strokes).

Done.

https://codereview.chromium.org/12548010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:62: for (int i = 0; i <
data.length; i++) {
On 2013/03/08 01:54:50, blois wrote:
> data.join(', ')?

Done.

https://codereview.chromium.org/12548010/diff/1/tools/dom/idl/dart/dart.idl
File tools/dom/idl/dart/dart.idl (right):

https://codereview.chromium.org/12548010/diff/1/tools/dom/idl/dart/dart.idl#n...
tools/dom/idl/dart/dart.idl:142: [Suppressed] any
arc([Optional=DefaultIsUndefined] float x, [Optional=DefaultIsUndefined] float
y, [Optional=DefaultIsUndefined] float radius, [Optional=DefaultIsUndefined]
float startAngle, [Optional=DefaultIsUndefined] float endAngle, boolean
anticlockwise);
On 2013/03/08 01:54:50, blois wrote:
> I believe you can remove the DefaultIsUndefined portion.

Done.

[blois, 2013-03-08 17:48:44]

lgtm

w/ one comment

https://codereview.chromium.org/12548010/diff/5001/tests/html/canvasrendering...
File tests/html/canvasrenderingcontext2d_test.dart (right):

https://codereview.chromium.org/12548010/diff/5001/tests/html/canvasrendering...
tests/html/canvasrenderingcontext2d_test.dart:46: var data = readPixel(x, y);
how about readPixel(x, y).any((p) => p != 0)?

[Andrei Mouravski, 2013-03-08 18:39:12]

Thanks! Submitting.

https://codereview.chromium.org/12548010/diff/5001/tests/html/canvasrendering...
File tests/html/canvasrenderingcontext2d_test.dart (right):

https://codereview.chromium.org/12548010/diff/5001/tests/html/canvasrendering...
tests/html/canvasrenderingcontext2d_test.dart:46: var data = readPixel(x, y);
On 2013/03/08 17:48:44, blois wrote:
> how about readPixel(x, y).any((p) => p != 0)?

Ooooh, you know how much I like one-liners.

[Andrei Mouravski, 2013-03-08 18:39:28]

Committed patchset #2 manually as r19707 (presubmit successful).