Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 12545080: Fix Frame.location on Windows in pkg/stack_trace. (Closed)

Created:
7 years, 8 months ago by nweiz
Modified:
7 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix Frame.location on Windows in pkg/stack_trace. Committed: https://code.google.com/p/dart/source/detail?r=20586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M pkg/stack_trace/test/frame_test.dart View 5 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 8 months ago (2013-03-27 21:35:32 UTC) #1
Bob Nystrom
LGTM.
7 years, 8 months ago (2013-03-27 21:36:30 UTC) #2
nweiz
7 years, 8 months ago (2013-03-27 21:37:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20586 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698