Issue 12545067: On x64 use 32bit idiv when possible instead of 64bit one.

Issue 12545067: On x64 use 32bit idiv when possible instead of 64bit one. (Closed)

Created:
7 years, 9 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

On x64 use 32bit idiv when possible instead of 64bit one. 64bit idiv requires twice as much cycles and has 2-3 times higher latency. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=20565

Patch Set 1 #

Patch Set 2 : Fix optimized pattern for kTRUNCDIV as well #

Total comments: 1

Patch Set 3 : rename movsxl to movsxd #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -12 lines)			Patch
M	runtime/vm/assembler_x64.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 2	1 chunk	+10 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View	1 2	2 chunks	+34 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_x64.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	3 chunks	+33 lines, -5 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 2	2 chunks	+53 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

I also fixed pattern in BinarySmiOpInstr for kTRUNCDIV. PTAL

7 years, 9 months ago (2013-03-27 16:20:52 UTC) #2

srdjan

LGTM https://codereview.chromium.org/12545067/diff/3001/runtime/vm/assembler_x64.h File runtime/vm/assembler_x64.h (right): https://codereview.chromium.org/12545067/diff/3001/runtime/vm/assembler_x64.h#newcode369 runtime/vm/assembler_x64.h:369: void movsxl(Register dst, const Address& src); Should this ...

7 years, 9 months ago (2013-03-27 16:26:52 UTC) #3

Vyacheslav Egorov (Google)

Renamed movsxl to movsxd to match Intel manual. Added a test for movsx r64, m64 ...

7 years, 9 months ago (2013-03-27 17:09:48 UTC) #4

Vyacheslav Egorov (Google)

7 years, 9 months ago (2013-03-27 17:14:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r20565 (presubmit successful).

Expand Messages | Collapse Messages