Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1254453002: Remove (for the time being) async-await from dart2js. (Closed)

Created:
5 years, 5 months ago by Anders Johnsen
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove (for the time being) async-await from dart2js. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/7ed648fb203a8b6882f2ea3c88452639b3465982

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +6 lines, -6 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Anders Johnsen
5 years, 5 months ago (2015-07-22 15:19:13 UTC) #2
floitsch
LGTM.
5 years, 5 months ago (2015-07-22 15:32:13 UTC) #3
Anders Johnsen
Committed patchset #1 (id:1) manually as 7ed648fb203a8b6882f2ea3c88452639b3465982 (presubmit successful).
5 years, 5 months ago (2015-07-22 15:38:44 UTC) #4
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1254453002/diff/1/pkg/compiler/lib/src/library_loader.dart File pkg/compiler/lib/src/library_loader.dart (right): https://codereview.chromium.org/1254453002/diff/1/pkg/compiler/lib/src/library_loader.dart#newcode533 pkg/compiler/lib/src/library_loader.dart:533: LibraryElement library) async { might be good to remove ...
5 years, 5 months ago (2015-07-23 00:03:07 UTC) #6
Siggi Cherem (dart-lang)
5 years, 5 months ago (2015-07-23 00:03:20 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698