Issue 12544024: Make Set.containsAll accept Iterable. Deprecate Set.isSubsetOf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12544024: Make Set.containsAll accept Iterable. Deprecate Set.isSubsetOf. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make Set.containsAll accept Iterable. Deprecate Set.isSubsetOf. This is a recommit of the earlier reverted CL with updated test expectations. Committed: https://code.google.com/p/dart/source/detail?r=19993

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -61 lines)			Patch
M	sdk/lib/collection/collections.dart	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	sdk/lib/collection/hash_set.dart	View	1 chunk	+11 lines, -4 lines	0 comments	Download
M	sdk/lib/collection/linked_hash_set.dart	View	1 chunk	+11 lines, -4 lines	0 comments	Download
M	sdk/lib/core/set.dart	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	3 chunks	+10 lines, -1 line	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	2 chunks	+5 lines, -15 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	2 chunks	+8 lines, -15 lines	0 comments	Download
M	tools/dom/src/CssClassSet.dart	View	1 chunk	+7 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Committed patchset #1 manually as r19993 (presubmit successful).

7 years, 9 months ago (2013-03-14 09:32:40 UTC) #2

floitsch

7 years, 9 months ago (2013-03-14 11:33:50 UTC) #3

Message was sent while issue was closed.

LGTM.

https://codereview.chromium.org/12544024/diff/1/tools/dom/src/CssClassSet.dart
File tools/dom/src/CssClassSet.dart (right):

https://codereview.chromium.org/12544024/diff/1/tools/dom/src/CssClassSet.dar...
tools/dom/src/CssClassSet.dart:114: Set<String> union(Collection<String> other)
=>
Set.

https://codereview.chromium.org/12544024/diff/1/tools/dom/src/CssClassSet.dar...
tools/dom/src/CssClassSet.dart:117: Set<String> difference(Collection<String>
other) =>
ditto.

Expand Messages | Collapse Messages