Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 12543033: Revert "Support optional function expression parameters in dart2js." (Closed)

Created:
7 years, 9 months ago by aam-me
Modified:
7 years, 9 months ago
Reviewers:
Johnni Winther, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Support optional function expression parameters in dart2js." This reverts r19832. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree_validator.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
aam-me
dart2dart is unhappy about the change. Reverting it. TBR.
7 years, 9 months ago (2013-03-12 01:45:19 UTC) #1
aam-me
Committed patchset #1 manually as r19835 (presubmit successful).
7 years, 9 months ago (2013-03-12 01:46:17 UTC) #2
ahe
7 years, 9 months ago (2013-03-12 06:22:24 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698