Issue 12543021: Allow more objects to be treated as ArrayBuffer and ArrayBufferView.

Issue 12543021: Allow more objects to be treated as ArrayBuffer and ArrayBufferView. (Closed)

Created:
7 years, 9 months ago by Anton Muhin

Modified:
7 years, 9 months ago

Reviewers:
podivilov, Mads Ager (google), blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow more objects to be treated as ArrayBuffer and ArrayBufferView. Temporary ugly hack. Eventually we'll just remap ArrayBuffer and ArrayBufferView to the proper dart:typeddata types. R=ager@google.com,blois@google.com,podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=19794

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -9 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View		6 chunks	+9 lines, -8 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/web_audio_dartium.darttemplate	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM https://codereview.chromium.org/12543021/diff/1/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (right): https://codereview.chromium.org/12543021/diff/1/tools/dom/scripts/htmldartgenerator.py#newcode234 tools/dom/scripts/htmldartgenerator.py:234: # TODO(antonm): temporary ugly hack. Let's expand on ...

7 years, 9 months ago (2013-03-11 14:13:18 UTC) #2

Anton Muhin

https://codereview.chromium.org/12543021/diff/1/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (right): https://codereview.chromium.org/12543021/diff/1/tools/dom/scripts/htmldartgenerator.py#newcode234 tools/dom/scripts/htmldartgenerator.py:234: # TODO(antonm): temporary ugly hack. On 2013/03/11 14:13:18, Mads ...

7 years, 9 months ago (2013-03-11 14:35:27 UTC) #3

Anton Muhin

7 years, 9 months ago (2013-03-11 14:36:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r19794 (presubmit successful).

Expand Messages | Collapse Messages