Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 12543014: Reapply Futureification. (Closed)

Created:
7 years, 9 months ago by Emily Fortuna
Modified:
7 years, 9 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply Futureification. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19590

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+850 lines, -172 lines) Patch
M samples/chat/dart_client/chat.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/DataSource.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 29 chunks +335 lines, -63 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 31 chunks +220 lines, -39 lines 0 comments Download
M tests/html/fileapi_test.dart View 4 chunks +144 lines, -50 lines 0 comments Download
M tests/html/xhr_cross_origin_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/xhr_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/generator.py View 5 chunks +36 lines, -4 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 3 chunks +49 lines, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 4 chunks +45 lines, -2 lines 0 comments Download
M tools/dom/scripts/monitored.py View 3 chunks +8 lines, -2 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
This reapplies the previous patch. The first patch set is the one that I committed ...
7 years, 9 months ago (2013-03-06 23:38:58 UTC) #1
blois
lgtm
7 years, 9 months ago (2013-03-07 00:09:32 UTC) #2
Emily Fortuna
7 years, 9 months ago (2013-03-07 00:14:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19590 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698